fix: Repository resource handles PermissionDenied status #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KasnocknDave
force-pushed
the
fix/repository-not-found-status
branch
from
ad25b51
to
f6bc098
Compare
Signed-off-by: David Hondl <[email protected]>
MisterMX
force-pushed
the
fix/repository-not-found-status
branch
from
f6bc098
to
0acaa90
Compare
MisterMX
approved these changes
Oct 1, 2024
|
Successfully created backport PR for |
|
/backport |
|
Backport failed for Please cherry-pick the changes locally. git fetch origin release-0.8
git worktree add -d .worktree/backport-200-to-release-0.8 origin/release-0.8
cd .worktree/backport-200-to-release-0.8
git checkout -b backport-200-to-release-0.8
ancref=$(git merge-base 1568f5c6aff887376617da09e55305736370d3de 0acaa902cc8c6a0a6c8f7803d744ad98921046ae)
git cherry-pick -x $ancref..0acaa902cc8c6a0a6c8f7803d744ad98921046ae |
|
Successfully created backport PR #203 for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #193
This code change handles the PermissionDenied error that gets returned by Argo CD when fetching a repository resource that doesn't exist yet. This is actually an issue within Argo CD, reported here: argoproj/argo-cd#20005.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Unit tests are adjusted and it has been tested by following the local testing steps via kind cluster.