Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add engine version for dbinstance update #2066

Merged

Conversation

akesser
Copy link
Contributor

@akesser akesser commented Jun 7, 2024

Description of your changes

Currently, when changing the engine version of a rds db instance, the new version is not send to aws. This leads to a) the database does not get updated and b) an update loop, as the isUpToDate call always returns false.

Fixes #

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

@haarchri
Copy link
Member

haarchri commented Jun 7, 2024

add update functionality back after #1765

@haarchri haarchri requested a review from MisterMX June 7, 2024 12:21
Copy link
Collaborator

@MisterMX MisterMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you very much @akesser!

@MisterMX MisterMX merged commit d17c9da into crossplane-contrib:master Jun 11, 2024
9 checks passed
Copy link

Successfully created backport PR #2069 for release-0.48.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants