Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eks): Add accessConfig #2097

Merged
merged 1 commit into from
Oct 4, 2024
Merged

feat(eks): Add accessConfig #2097

merged 1 commit into from
Oct 4, 2024

Conversation

simwak
Copy link
Contributor

@simwak simwak commented Oct 2, 2024

Adds the possibility to use new authentication modes for a EKS cluster.

I have:

  • Read and followed Crossplane's [contribution process].
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

  • Added the attribute to a existing cluster
  • Created a new cluster with the attribute

@simwak simwak marked this pull request as draft October 4, 2024 06:24
@simwak
feat(eks): Add accessConfig
1cf1124 
Signed-off-by: Simon Wakenhut <[email protected]>
@MisterMX MisterMX marked this pull request as ready for review October 4, 2024 06:56
MisterMX
MisterMX approved these changes Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@MisterMX MisterMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you very much @simwak!

@MisterMX MisterMX merged commit bb2b23e into crossplane-contrib:master Oct 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MisterMX MisterMX MisterMX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simwak @MisterMX