Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Explicitly provide no-op logger by default #2099

Merged
merged 1 commit into from
Oct 4, 2024
Merged

fix: Explicitly provide no-op logger by default #2099

merged 1 commit into from
Oct 4, 2024

Conversation

simwak
Copy link
Contributor

@simwak simwak commented Oct 4, 2024

Description of your changes

Closes #2081

I have:

  • Read and followed Crossplane's [contribution process].
  • Run make reviewable test to ensure this PR is ready for review.

MisterMX
MisterMX approved these changes Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@MisterMX MisterMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you very much for this small fix @simwak!

@MisterMX MisterMX merged commit e36fb00 into crossplane-contrib:master Oct 4, 2024
9 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

Successfully created backport PR #2100 for release-0.49.

@github-actions github-actions bot mentioned this pull request Oct 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MisterMX MisterMX MisterMX approved these changes

Assignees
No one assigned
Labels
backport release-0.49
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[controller-runtime] log.SetLogger(...) was never called; logs will not be displayed.
2 participants
@simwak @MisterMX