Merge pull request #143 from wotolom/SharedWithGroupsObservation-omit…

…empty-fields fix(groups): SharedWithGroupsObservation fields no longer required
crossplane-contrib · May 8, 2024 · 3e72375 · 3e72375
2 parents 733e463 + 7dadcaa
commit 3e72375
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 11 deletions.
diff --git a/apis/groups/v1alpha1/group_types.go b/apis/groups/v1alpha1/group_types.go
@@ -246,11 +246,11 @@ type GroupObservation struct {
 
 // SharedWithGroupsObservation is the observed state of a SharedWithGroups.
 type SharedWithGroupsObservation struct {
-	GroupID          *int         `json:"groupId"`
-	GroupName        *string      `json:"groupName"`
-	GroupFullPath    *string      `json:"groupFullPath"`
-	GroupAccessLevel *int         `json:"groupAccessLevel"`
-	ExpiresAt        *metav1.Time `json:"expiresAt"`
+	GroupID          *int         `json:"groupId,omitempty"`
+	GroupName        *string      `json:"groupName,omitempty"`
+	GroupFullPath    *string      `json:"groupFullPath,omitempty"`
+	GroupAccessLevel *int         `json:"groupAccessLevel,omitempty"`
+	ExpiresAt        *metav1.Time `json:"expiresAt,omitempty"`
 }
 
 // A GroupSpec defines the desired state of a Gitlab Group.

diff --git a/package/crds/groups.gitlab.crossplane.io_groups.yaml b/package/crds/groups.gitlab.crossplane.io_groups.yaml
@@ -552,12 +552,6 @@ spec:
                           type: integer
                         groupName:
                           type: string
-                      required:
-                      - expiresAt
-                      - groupAccessLevel
-                      - groupFullPath
-                      - groupId
-                      - groupName
                       type: object
                     type: array
                   statistics: