chore: rename PrivateToken providerConfigType to PersonalAccessToken …

…to aline with gitlab's naming instead of third party library naming

README.md

@@ -32,7 +32,7 @@ spec:
   baseURL: https://gitlab.com/
   credentials:
     source: Secret
-    method: PrivateToken
+    method: PersonalAccessToken
     secretRef:
       namespace: crossplane-system
       name: gitlab-credentials

apis/v1beta1/providerconfig_types.go

@@ -22,17 +22,17 @@ import (
 )
 
 const (
-	// BasicAuth gitlab BasicAuth method of authentification
+	// BasicAuth is gitlab's BasicAuth method of authentification that needs a username and a password
 	BasicAuth AuthType = "BasicAuth"
 
-	// JobToken gitlab JobToken method of authentification
+	// JobToken is gitlab's JobToken method of authentification
 	JobToken AuthType = "JobToken"
 
-	// OAuthToken gitlab OAuthToken method of authentification
+	// OAuthToken is gitlab's OAuthToken method of authentification
 	OAuthToken AuthType = "OAuthToken"
 
-	// PrivateToken gitlab PrivateToken method of authentification.
-	PrivateToken AuthType = "PrivateToken"
+	// PersonalAccessToken is gitlab's PersonalAccessToken method of authentification.
+	PersonalAccessToken AuthType = "PersonalAccessToken"
 )
 
 // AuthType represents an authentication type within GitLab.
@@ -57,7 +57,7 @@ type ProviderCredentials struct {
 	// +kubebuilder:validation:Enum=None;Secret;InjectedIdentity;Environment;Filesystem
 	Source xpv1.CredentialsSource `json:"source"`
 
-	// Method of authentification can be BasicAuth, JobToken, OAuthToken or PrivateToken (default)
+	// Method of authentification can be BasicAuth, JobToken, OAuthToken or PersonalAccessToken (default)
 	// +optional
 	Method AuthType `json:"method"`
 

examples/providerconfig/provider.yaml

@@ -8,7 +8,7 @@ spec:
   baseURL: https://gitlab.com/
   credentials:
     source: Secret
-    method: PrivateToken
+    method: PersonalAccessToken
     secretRef:
       namespace: crossplane-system
       name: gitlab-credentials

package/crds/gitlab.crossplane.io_providerconfigs.yaml

@@ -82,7 +82,7 @@ spec:
                     type: object
                   method:
                     description: Method of authentification can be BasicAuth, JobToken,
-                      OAuthToken or PrivateToken (default)
+                      OAuthToken or PersonalAccessToken (default)
                     type: string
                   secretRef:
                     description: |-

pkg/clients/gitlab.go

@@ -86,7 +86,7 @@ func NewClient(c Config) *gitlab.Client {
 		cl, err = gitlab.NewJobClient(c.Token, options...)
 	case v1beta1.OAuthToken:
 		cl, err = gitlab.NewOAuthClient(c.Token, options...)
-	case v1beta1.PrivateToken:
+	case v1beta1.PersonalAccessToken:
 		cl, err = gitlab.NewClient(c.Token, options...)
 	default:
 		cl, err = gitlab.NewClient(c.Token, options...)