feat(group): Add support for group variables #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IntaSlapna
force-pushed
the
feature/91
branch
2 times, most recently
from
c4c386f
to
d065240
Compare
|
Can you separate the changes from this and #103? It is hard to see what changes belong in which PR. |
IntaSlapna
force-pushed
the
feature/91
branch
from
d065240
to
430bf39
Compare
MisterMX
requested changes
Sep 8, 2023
Signed-off-by: IntaSlapna <[email protected]>
IntaSlapna
force-pushed
the
feature/91
branch
from
430bf39
to
6397817
Compare
MisterMX
approved these changes
Sep 8, 2023
There was a problem hiding this comment.
LGTM. Thank you very much for your contribution @IntaSlapna!
MisterMX
changed the title
markussiebert
pushed a commit
to markussiebert/provider-gitlab
that referenced
this pull request
Apr 8, 2024
feat(group): Add support for group variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Issue #91 : created groupVariable controller
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
unit testing, make reviewable test PASS