Beta mgmt policy #137
Beta mgmt policy #137
Conversation
jwhitcraft
force-pushed
the
betaMgmtPolicy
branch
from
8cad824
to
cfe56cf
Compare
Use the upstream feature flag to enable the Beta Management Policy support. fixes: crossplane-contrib#136 Signed-off-by: Jon Whitcraft <[email protected]>
jwhitcraft
force-pushed
the
betaMgmtPolicy
branch
from
cfe56cf
to
3413bd6
Compare
|
The provider uses https://github.com/crossplane/crossplane-runtime |
From the looks of it, the feature went beta in 1.14.0rc1: crossplane/crossplane-runtime@55a8c10 |
| o.Features.Enable(features.EnableAlphaManagementPolicies) | ||
| log.Info("Alpha feature enabled", "flag", features.EnableAlphaManagementPolicies) | ||
| o.Features.Enable(feature.EnableBetaManagementPolicies) | ||
| log.Info("Beta Management Policies feature enabled", "flag", feature.EnableBetaManagementPolicies) |
There was a problem hiding this comment.
features.EnableAlphaManagementPolicies is a provider feature flag that does not come with the runtime. Changing this wont work.
There was a problem hiding this comment.
oh i see, i guess i'll go back to the drawing board and see if i can get this provided updated to 1.15.x so we can use the beta feature flag.
|
Closing this, since the underlying issue #136 is solved. |
Description of your changes
This enabled the using the Beta Management Policy Feature Flag
Fixes #136
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Built and tested in our test controlplane