feat: SamlGroupLinks #144
Merged
feat: SamlGroupLinks #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jholt96
force-pushed
the
feature-add-groupsamllink
branch
from
16523eb
to
9887214
Compare
MisterMX
requested changes
May 13, 2024
jholt96
force-pushed
the
feature-add-groupsamllink
branch
4 times, most recently
from
e4962e6
to
84e3570
Compare
jholt96
force-pushed
the
feature-add-groupsamllink
branch
2 times, most recently
from
07fd315
to
e210894
Compare
|
Resolved previous lint Issues and ran the golangci-lint local with no errors |
|
@jholt96 I think there is still an issue with the linter. Can you check again? |
Signed-off-by: Josh Holt <[email protected]>
jholt96
force-pushed
the
feature-add-groupsamllink
branch
from
e210894
to
07e6a88
Compare
Just added the comment that the job was complaining about. Sorry about that. I figured running the tool locally would be the same output. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR adds SamlGroupLink functionality. This allows users to tie Saml groups to Gitlab groups using the samlGroupSync feature for Gitlab EE.
https://docs.gitlab.com/ee/user/group/saml_sso/group_sync.html
I have:
make reviewable testto ensure this PR is ready for review.=> fails
How has this code been tested