feat: deprecate emails_disabled in favor of emails_enabled #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dario Zachow <[email protected]>
Signed-off-by: Dario Zachow <[email protected]>
Signed-off-by: Dario Zachow <[email protected]>
Signed-off-by: Dario Zachow <[email protected]>
Signed-off-by: Dario Zachow <[email protected]>
MisterMX
requested changes
Aug 20, 2024
Signed-off-by: Dario Zachow <[email protected]>
dariozachow
changed the title
MisterMX
requested changes
Aug 21, 2024
Co-authored-by: MisterMX <[email protected]> Signed-off-by: Dario Zachow <[email protected]>
Signed-off-by: Dario Zachow <[email protected]>
Signed-off-by: Dario Zachow <[email protected]>
Signed-off-by: Dario Zachow <[email protected]>
MisterMX
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR fixes the Issue with Gitlab 16, where emails_disabled has been renamed to emails_enabled on groups.
This is a breaking change even though It should have been none breaking as discussed here.
But when implementing the changes it felt awkward to work with 2 fields witch are dependend on each other.
This makes a clean representation of the actual Gitlab-API.
The go-gitlab dependency has been updated to the latest version as well.
Fixes #141
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Tests have been updated to test for emailsEnabled instead of emailsDisabled