fix(project/hook)!: hooksecret as reference #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariozachow
force-pushed
the
fix/hooksecret-as-reference
branch
2 times, most recently
from
c5f59d2
to
6fcb3f8
Compare
dariozachow
changed the title
MisterMX
changed the title
MisterMX
reviewed
Aug 23, 2024
There was a problem hiding this comment.
LGTM so far. Thanks a lot @dariozachow. Could you squash your changes into a single commit?
Signed-off-by: Dario Zachow <[email protected]>
dariozachow
force-pushed
the
fix/hooksecret-as-reference
branch
from
6fcb3f8
to
d23132b
Compare
janwillies
approved these changes
Aug 23, 2024
|
well that was a race condition :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR changes the Hook Resource to take a secret reference as an input instead of having the token directly in the spec fields.
Fixes #133 and #153
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
New Unit tests have been added to confirm the proper usage of the secret in the hook controller.
Old Unit tests have been updated to use the token as a secret reference