Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(projects.deploykey): Add nil check before pointer deref for CreatedAt in controller #95

Merged
merged 1 commit into from
Aug 10, 2023
Merged

fix(projects.deploykey): Add nil check before pointer deref for CreatedAt in controller #95

merged 1 commit into from
Aug 10, 2023

Conversation

lvvorovi
Copy link

@lvvorovi lvvorovi commented Aug 9, 2023

Description of your changes

  • Add nil check before pointer deref for CreatedAt in controller

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

MisterMX
MisterMX approved these changes Aug 10, 2023
View reviewed changes
Copy link
Collaborator

@MisterMX MisterMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you very much @lvvorovi!

@MisterMX MisterMX merged commit 4dbdfdb into crossplane-contrib:master Aug 10, 2023
7 checks passed
markussiebert pushed a commit to markussiebert/provider-gitlab that referenced this pull request Apr 8, 2024
@MisterMX
Merge pull request crossplane-contrib#95 from lvvorovi/issue/5
e7301dd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MisterMX MisterMX MisterMX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lvvorovi @MisterMX