Add references to Cognito UserPool #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbbush
requested review from
ulucinar,
sergenyalcin and
turkenf
as code owners
mbbush
force-pushed
the
cognito-references
branch
from
6e47356 to
534bd8a
Compare
|
/test-examples="examples/s3/object.yaml" |
|
/test-examples="examples/cognitoidp/userpool.yaml" |
mbbush
commented
Dec 13, 2023
config/cognitoidp/config.go
Outdated
Comment on lines
57
to
63
| r.References["email_configuration.configuration_set"] = config.Reference{ | ||
| TerraformName: "aws_ses_configuration_set", | ||
| } | ||
| r.References["email_configuration.source_arn"] = config.Reference{ | ||
| TerraformName: "aws_ses_email_identity", | ||
| Extractor: common.PathARNExtractor, | ||
| } |
There was a problem hiding this comment.
So it turns out there are actually two terraform resources for these objects, these and the corresponding aws_sesv2_ ones. As far as I can tell, they are simply two different interfaces for the same objects, with the same ARNs. I'm conflicted about what to do here, but perhaps these would be better left off?
There was a problem hiding this comment.
It seems more logical not to define a reference for these for now.
mbbush
force-pushed
the
cognito-references
branch
from
4112e1b to
11b749f
Compare
|
/test-examples="examples/cognitoidp/userpool.yaml" |
1 similar comment
|
/test-examples="examples/cognitoidp/userpool.yaml" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Adds references to cognito user pool, and makes the example uptestable. I couldn't use the Object.s3 resource because of #978, but the (deprecated in the terraform provider) BucketObject.s3 resource works fine.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
make e2e UPTEST_EXAMPLE_LIST=examples/cognitoidp/userpool.yaml