Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable lateinit for enabledCloudwatchLogsExports in rds Cluster #1644

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

turkenf
Copy link
Collaborator

@turkenf turkenf commented Jan 17, 2025

Description of your changes

Disable late init for enabledCloudwatchLogsExports in rds Cluster

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

@turkenf
Copy link
Collaborator Author

turkenf commented Jan 23, 2025

/test-examples="examples/rds/v1beta1/cluster.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Jan 23, 2025

/test-examples="examples/rds/v1beta2/cluster.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Jan 24, 2025

/test-examples="examples/rds/v1beta2/cluster.yaml"

@turkenf turkenf marked this pull request as ready for review January 24, 2025 18:49
Copy link
Collaborator

@mergenci mergenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @turkenf 🙏 LGTM.

@turkenf turkenf merged commit 6e0f4f2 into crossplane-contrib:main Jan 28, 2025
9 checks passed
@turkenf turkenf deleted the z-t-587 branch January 28, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants