Indent generated.lst and add newlines #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickard-von-essen
requested review from
ulucinar,
sergenyalcin and
turkenf
as code owners
To make diffs easy to inspect where resources are added/removed Signed-off-by: Rickard von Essen <[email protected]>
Signed-off-by: Rickard von Essen <[email protected]>
rickard-von-essen
force-pushed
the
indent-generated-lst
branch
2 times, most recently
from
caef166 to
e3454ed
Compare
turkenf
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
Thank you for taking care of this @rickard-von-essen, LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Add newlines and indentation to the JSON array in
config/generated.lstto make it easier to review diffs etc.I have:
make reviewableto ensure this PR is ready for review.Addedbackport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested