-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs to point to providers sourced from xpkg.crossplane.io. Remove terminology related to Upbound Marketplace #880
Conversation
✅ Deploy Preview for crossplane ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
63180b0
to
e2c9628
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great @cwilhit, thanks for driving these changes in the docs, really appreciate it! Feel free to sync directly with me if that's higher bandwidth to get aligned on any of this feedback 🙇♂️
…move terminology related to Upbound Marketplace Signed-off-by: Craig D Wilhite <[email protected]>
Signed-off-by: Craig D Wilhite <[email protected]>
0be8442
to
e6d0e7f
Compare
…quickstart Signed-off-by: Craig Wilhite <[email protected]>
content/master/concepts/packages.md
Outdated
spec: | ||
package: xpkg.upbound.io/upbound/platform-ref-aws@sha256:a30ad655c7699218d9234285d838d85582f015d02f7f061f8486b28248fd7db7 | ||
package: xpkg.crossplane.io/crossplane-contrib/configuration-quickstart@sha256:a30ad655c7699218d9234285d838d85582f015d02f7f061f8486b28248fd7db7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this configuration package still needs to be pushed, I don't see anything at https://github.com/orgs/crossplane-contrib/packages?repo_name=configuration-quickstart yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i also bet this digest won't be the same anymore either, so try to update it to whatever the digest is for the v0.1.0 package that gets published soon. i think this comment applies to previous versions of the docs also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cwilhit, it's published now! https://github.com/crossplane-contrib/configuration-quickstart/pkgs/container/configuration-quickstart
❯ k get pkg
NAME INSTALLED HEALTHY PACKAGE AGE
configuration.pkg.crossplane.io/crossplane-contrib-configuration-quickstart True True xpkg.crossplane.io/crossplane-contrib/configuration-quickstart:v0.1.0 81s
I think the digest is:
xpkg.crossplane.io/crossplane-contrib/configuration-quickstart@sha256:ef9795d146190637351a5c5848e0bab5e0c190fec7780f6c426fbffa0cb68358
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Updating docs now...
content/master/software/upgrade.md
Outdated
For example, in v1.15.0 Crossplane changed the default image registry from | ||
`index.docker.io` to `xpkg.upbound.io`. Upgrading Crossplane from a version | ||
For example, in v1.20.0 Crossplane changed the default image registry from | ||
`index.docker.io` to `xpkg.crossplane.io`. Upgrading Crossplane from a version | ||
before v1.15.0 updates the default package registry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update this to v1.20.0
also?
Looks like 59 new Vale errors to clean up too 😅 - after #810, we're keeping Vale errors completely clean. Warnings are OK, but errors should be fixed. That #810 PR should have some hints on how to ignore words that are spelled correctly. Let me know if you need any help! 🙇♂️ |
Signed-off-by: Craig Wilhite <[email protected]>
…1.20 Signed-off-by: Craig Wilhite <[email protected]>
Thanks again for driving this @cwilhit, really appreciate your efforts here! 🤩 |
This change does two things:
crossplane-contrib
.Both of these are done to align with the proposed policy changes in crossplane/crossplane#6290