Skip to content

Commit

Permalink
Add TODO for Plugin Framework external client.
Browse files Browse the repository at this point in the history
Signed-off-by: Cem Mergenci <[email protected]>
  • Loading branch information
mergenci committed Jan 29, 2025
1 parent 2f967cf commit cfc7b7c
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions pkg/controller/external_tfpluginfw.go
Original file line number Diff line number Diff line change
Expand Up @@ -330,6 +330,8 @@ func (n *terraformPluginFrameworkExternalClient) Observe(ctx context.Context, mg
}
}

// TODO(cem): Consider skipping diff calculation to avoid config validation
// errors in the import path. See https://github.com/crossplane/upjet/pull/461
planResponse, hasDiff, err := n.getDiffPlanResponse(ctx, tfStateValue)
if err != nil {
return managed.ExternalObservation{}, errors.Wrap(err, "cannot calculate diff")
Expand Down

0 comments on commit cfc7b7c

Please sign in to comment.