Remove diff calculation in observe-only reconciliation #461
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes crossplane-contrib/provider-upjet-aws#1597.
While importing a DynamoDB Table, in the linked issue, Terraform executes
CustomizeDiff
functions when Upjet calculates the diff inObserve()
. One of theCustomizeDiff
functions is a validation function that checks whether the configuration that is subject to diff is valid. Because the configuration is practically empty — it only contains the resource name in the import path — validation fails and returns an error, which in turn causes ourObserve()
to fail.I've checked how the behavior of managed reconciler changes for observe-only reconciliation. When Upjet always returns
ResourceUpToDate = true
, this block executes. Otherwise, when Upjet calculates the diff and returnsResourceUpToDate
accordingly, this block executes in caseResourceUpToDate = false
. The difference between those two blocks are (1) debug messages and (2) metric records.The difference doesn't matter for the import path, in which
ResourceUpToDate
doesn't make much sense. We can considerResourceUpToDate = true
, by definition, which is the case in this PR. The difference might matter in observe-only reconciliation that is not an import operation.TODO:
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
Manually, using the resource manifest given in the linked issue above.