Parametrize the registry name of the provider #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergenyalcin
force-pushed
the
parametrize-registry
branch
from
2cd9fb2 to
9373663
Compare
sergenyalcin
requested review from
ulucinar,
erhancagirici and
mergenci
as code owners
Signed-off-by: Sergen Yalçın <[email protected]>
sergenyalcin
force-pushed
the
parametrize-registry
branch
from
9373663 to
5dbd74a
Compare
mergenci
approved these changes
Jan 23, 2025
|
Successfully created backport PR for |
mergenci
added a commit
to mergenci/provider-aws
that referenced
this pull request
Jan 30, 2025
Consumed Upjet PRs: - crossplane/upjet#454 - crossplane/upjet#450 - crossplane/upjet#451 - crossplane/upjet#437 - crossplane/upjet#462 - crossplane/upjet#461 Signed-off-by: Cem Mergenci <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR parametrizes the registry name of the provider. For some private registries the hardcoded registry is not valid.
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested