ses: Add ses upload subcommand (SCRD-8432) #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Mar 15, 2019
skazi0
force-pushed
the
ses-commands
branch
2 times, most recently
from
b36fa09 to
9ca7c22
Compare
By default it is detected based on the OS release for local machine. If needed, it could be overridden using CROWBAR_CLOUD_VERSION environment variable.
The `ses upload` subcommand can be used to upload yaml file with SES configuration to crowbar.
houndci-bot
reviewed
Mar 18, 2019
JanZerebecki
previously approved these changes
Mar 18, 2019
skazi0
commented
Mar 19, 2019
Upgrade version check was re-doing the check done for cloud_version. Re-using this part gives added value of "passing" the override information from `CROWBAR_CLOUD_VERSION` to upgrade subcommands.
stefannica
changed the title
JanZerebecki
approved these changes
Apr 2, 2019
jdsn
approved these changes
Apr 2, 2019
4 tasks
|
Backport was not really needed as crowbar-client doesn't have per-release branches. This #196 should be enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ses uploadsubcommand can be used to upload yaml file with SES configuration to crowbar.NOTE there are couple of changes included in this PR which are not strictly related to SES but rather refactoring and/or pre-requisites for actual SES commands.