Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dolby Surround (0040) to model parameters for VSX-1130 #36

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

glassbase
Copy link

No description provided.

@crowbarz
Copy link
Owner

crowbarz commented Oct 8, 2024

Thanks for the PR.

The VSX-1130 is closely related to the VSX-930 for which there is already an override definition containing the Dolby Surround extra listening mode, and two other modes. Does this override work on your VSX-1130? If it does, then a cleaner change would be to update the regex for the VSX-930 override definition to match the VSX-1130 as well.

@glassbase
Copy link
Author

glassbase commented Oct 27, 2024

I would say not close enough.

I got video info via your component and I assume this will disable querying the video info 'PARAM_ENABLED_FUNCTIONS: PARAM_ENABLED_FUNCTIONS_NO_VIDEO'

@glassbase
Copy link
Author

Ok, tested that PARAM_ENABLED_FUNCTIONS: PARAM_ENABLED_FUNCTIONS_NO_VIDEO and I lost all my video info, so that is not compatible with VSX1130

Added extended stereo and advanced stereo to sound modes as well.

@crowbarz
Copy link
Owner

crowbarz commented Nov 4, 2024

I'm confused that your VSX-1130 loses video info with PARAM_ENABLED_FUNCTIONS: PARAM_ENABLED_FUNCTIONS_NO_VIDEO included. On my VSX-930, the extra query_video_* commands shown below are sent without the above config, but my AVR never returns anything back for them:

DEBUG (MainThread) [aiopioneer.pioneer_avr] sending command: ?VTC
DEBUG (MainThread) [aiopioneer.pioneer_avr] sending command: ?VTB
DEBUG (MainThread) [aiopioneer.pioneer_avr] AVR command query_video_converter returned error: E03
DEBUG (MainThread) [aiopioneer.pioneer_avr] sending command: ?VTD
DEBUG (MainThread) [aiopioneer.pioneer_avr] AVR command query_video_pure_cinema returned error: E03
DEBUG (MainThread) [aiopioneer.pioneer_avr] sending command: ?VTE
DEBUG (MainThread) [aiopioneer.pioneer_avr] AVR command query_video_prog_motion returned error: E03
DEBUG (MainThread) [aiopioneer.pioneer_avr] sending command: ?VTF
DEBUG (MainThread) [aiopioneer.pioneer_avr] AVR command query_video_stream_smoother returned error: E03
DEBUG (MainThread) [aiopioneer.pioneer_avr] sending command: ?VTG
DEBUG (MainThread) [aiopioneer.pioneer_avr] AVR command query_video_advanced_video_adjust returned error: E03
DEBUG (MainThread) [aiopioneer.pioneer_avr] sending command: ?VTH
DEBUG (MainThread) [aiopioneer.pioneer_avr] AVR command query_video_ynr returned error: E03
DEBUG (MainThread) [aiopioneer.pioneer_avr] sending command: ?VTI
DEBUG (MainThread) [aiopioneer.pioneer_avr] AVR command query_video_cnr returned error: E03
DEBUG (MainThread) [aiopioneer.pioneer_avr] sending command: ?VTJ
DEBUG (MainThread) [aiopioneer.pioneer_avr] AVR command query_video_bnr returned error: E03
DEBUG (MainThread) [aiopioneer.pioneer_avr] sending command: ?VTK
DEBUG (MainThread) [aiopioneer.pioneer_avr] AVR command query_video_mnr returned error: E03
DEBUG (MainThread) [aiopioneer.pioneer_avr] sending command: ?VTL
DEBUG (MainThread) [aiopioneer.pioneer_avr] AVR command query_video_detail returned error: E03
DEBUG (MainThread) [aiopioneer.pioneer_avr] sending command: ?VTM
DEBUG (MainThread) [aiopioneer.pioneer_avr] AVR command query_video_sharpness returned error: E04
DEBUG (MainThread) [aiopioneer.pioneer_avr] sending command: ?VTN
DEBUG (MainThread) [aiopioneer.pioneer_avr] AVR command query_video_brightness returned error: E03
DEBUG (MainThread) [aiopioneer.pioneer_avr] sending command: ?VTO
DEBUG (MainThread) [aiopioneer.pioneer_avr] AVR command query_video_contrast returned error: E03
DEBUG (MainThread) [aiopioneer.pioneer_avr] sending command: ?VTP
DEBUG (MainThread) [aiopioneer.pioneer_avr] AVR command query_video_hue returned error: E03
DEBUG (MainThread) [aiopioneer.pioneer_avr] sending command: ?VTQ
DEBUG (MainThread) [aiopioneer.pioneer_avr] AVR command query_video_chroma returned error: E03
DEBUG (MainThread) [aiopioneer.pioneer_avr] sending command: ?VTR
DEBUG (MainThread) [aiopioneer.pioneer_avr] AVR command query_video_black_setup returned error: E03
DEBUG (MainThread) [aiopioneer.pioneer_avr] sending command: ?VTS
DEBUG (MainThread) [aiopioneer.pioneer_avr] AVR command query_video_aspect returned error: E03

The default configuration also results in ?VST being sent to query video info, but the AVR seems to automatically send unsolicited VST video info responses (populating input/output resolution, colour format, bits, etc.) whenever the video changes anyway thus the query seems superfluous.

What type of extra video information do you get from your VSX-1130? I understood that the VSX-1130 specs are almost identical to the VSX-930, so I am surprised with your test results.

@glassbase
Copy link
Author

let me re-test to confirm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants