Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): Follow up test fix to target correct extension method. #273

Conversation

EvilKot
Copy link
Contributor

@EvilKot EvilKot commented Oct 16, 2024

Related to PR #271

@EvilKot
Copy link
Contributor Author

EvilKot commented Oct 16, 2024

Noticed issue with the test, since TestUtils also provides ToQueryString extension method, however the one in the InternalExtensions class should be actually tested.

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.38%. Comparing base (f45d418) to head (b304c20).
Report is 113 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #273       +/-   ##
===========================================
+ Coverage   50.38%   63.38%   +13.00%     
===========================================
  Files         277      399      +122     
  Lines        3688     6084     +2396     
  Branches        0      501      +501     
===========================================
+ Hits         1858     3856     +1998     
- Misses       1830     2189      +359     
- Partials        0       39       +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EvilKot
Copy link
Contributor Author

EvilKot commented Oct 16, 2024

cc: @andrii-bodnar

@andrii-bodnar
Copy link
Member

@EvilKot thank you!

@andrii-bodnar andrii-bodnar merged commit f1c2df1 into crowdin:main Oct 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants