Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): Refactor Core directory in the Crowdin.Api.Tests #278

Conversation

EvilKot
Copy link
Contributor

@EvilKot EvilKot commented Nov 7, 2024

Closes #272
Resubmitting PR #274

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.46%. Comparing base (f45d418) to head (2632b43).
Report is 116 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #278       +/-   ##
===========================================
+ Coverage   50.38%   63.46%   +13.08%     
===========================================
  Files         277      400      +123     
  Lines        3688     6096     +2408     
  Branches        0      503      +503     
===========================================
+ Hits         1858     3868     +2010     
- Misses       1830     2189      +359     
- Partials        0       39       +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@innomaxx innomaxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

Copy link
Member

@andrii-bodnar andrii-bodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EvilKot thanks a lot! 🚀

@andrii-bodnar andrii-bodnar merged commit c09619f into crowdin:main Nov 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Core directory in the Crowdin.Api.Tests
3 participants