-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update Screenshot Functionality + Screenshot Automation #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update target to 35 and compile to 34; - add automation test that will send screenshot;
- new API for update screenshot; - new models for screenshot response; - revert to target 33 - breaks broadcast functionality;
- update documentation; - add ability to set name from controls;
- update launch icons; - remove automator dependency;
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #272 +/- ##
============================================
- Coverage 61.20% 59.32% -1.88%
- Complexity 367 376 +9
============================================
Files 55 57 +2
Lines 1884 2008 +124
Branches 305 316 +11
============================================
+ Hits 1153 1191 +38
- Misses 523 598 +75
- Partials 208 219 +11 ☔ View full report in Codecov by Sentry. |
example/src/androidTest/java/com/crowdin/platform/example/ScreenshotAutomationTest.kt
Outdated
Show resolved
Hide resolved
- trim screenshot name before upload with check for empty string; - move toast position to top;
- add stroke for toast background;
Co-authored-by: Andrii Bodnar <[email protected]>
andrii-bodnar
approved these changes
Nov 28, 2024
andrii-bodnar
changed the title
feat: Update Screenshot Functionality
feat: Update Screenshot Functionality + Screenshot Automation
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the screenshot functionality by introducing the ability to provide a
screenshotName
when generating screenshots from the app. The SDK will now use the providedscreenshotName
to search for an existing screenshot on the platform.API Changes:
screenshotName
parameterDevelopers can now specify a name for the screenshot, making it easier to track and update screenshots on the platform.
Updated Methods:
and
Additional changes:
screenshotName
parameter can be specified through the controls widget when the screenshot functionality is enabled.