cscli metrics: explicit message "no bouncer metrics found" (#3155)

cmd/crowdsec-cli/climetrics/statbouncer.go

@@ -447,8 +447,15 @@ func (s *statBouncer) bouncerTable(out io.Writer, bouncerName string, wantColor
 }
 
 // Table displays a table of metrics for each bouncer
-func (s *statBouncer) Table(out io.Writer, wantColor string, noUnit bool, _ bool) {
+func (s *statBouncer) Table(out io.Writer, wantColor string, noUnit bool, showEmpty bool) {
+	found := false
+
 	for _, bouncerName := range maptools.SortedKeys(s.aggOverOrigin) {
 		s.bouncerTable(out, bouncerName, wantColor, noUnit)
+		found = true
+	}
+
+	if !found && showEmpty {
+		io.WriteString(out, "No bouncer metrics found.\n\n")
 	}
 }

test/bats/08_metrics_bouncer.bats

@@ -23,10 +23,15 @@ teardown() {
 
 #----------
 
-@test "cscli metrics show bouncers" {
-    # there are no bouncers, so no metrics yet
+@test "cscli metrics show bouncers (empty)" {
+    # this message is given only if we ask explicitly for bouncers
+    notfound="No bouncer metrics found."
+
     rune -0 cscli metrics show bouncers
-    refute_output
+    assert_output "$notfound"
+
+    rune -0 cscli metrics list
+    refute_output "$notfound"
 }
 
 @test "rc usage metrics (empty payload)" {