Validate configuration before reloading crowdsec in the cron

[blotus]

The cron installed by default will reload crowdsec automatically if the hub was updated, but it won't check if the configuration is valid first.
This can lead to an outage if any part of the configuration is invalid.

[github-actions]

@blotus: Thanks for opening an issue, it is currently awaiting triage.

In the meantime, you can:

1. Check Crowdsec Documentation to see if your issue can be self resolved.
2. You can also join our Discord.
3. Check Releases to make sure your agent is on the latest version.

Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

[github-actions]

@blotus: There are no 'kind' label on this issue. You need a 'kind' label to start the triage process.

• /kind feature
• /kind enhancement
• /kind bug
• /kind packaging

Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

[mmetc]

This should be done in systemd (ExecReload) so we're sure there is a trace in the logs, no? cron output often goes to /dev/null

[mmetc]

The problem is discussed in systemd/systemd#2175

I see the solution would be

ExecReload=sh -c '/usr/local/bin/crowdsec -t /etc/crowdsec/config.yaml && /bin/kill -HUP $MAINPID'

or (untested) simply provide multiple ExecReload directives which are executed sequentially until one of them fails.

but from what I read in the above issue, shouldn't we also notify systemd of reload, stop etcetera? Currently we only notify it of a successful start.

https://github.com/coreos/go-systemd/blob/main/daemon/sdnotify.go

Edit: and a watchdog?