Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systemd: check configuration before attempting reload #2861

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Feb 26, 2024

Fix #2831

freebsd already does it, nothing to add there

@mmetc mmetc added this to the 1.6.1 milestone Feb 26, 2024
Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.98%. Comparing base (a23fe06) to head (1f56c94).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2861      +/-   ##
==========================================
+ Coverage   57.97%   57.98%   +0.01%     
==========================================
  Files         240      240              
  Lines       31040    31040              
==========================================
+ Hits        17994    17998       +4     
  Misses      11413    11413              
+ Partials     1633     1629       -4     
Flag Coverage Δ
bats 37.98% <ø> (ø)
unit-linux 52.28% <ø> (+<0.01%) ⬆️
unit-windows 47.76% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc merged commit 8e9e091 into master Feb 26, 2024
19 checks passed
@mmetc mmetc deleted the reload-check-config branch February 26, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate configuration before reloading crowdsec in the cron
2 participants