Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[crowdsec] Add notification filter to profiles #2345

Closed

Conversation

LaurenceJJones
Copy link
Contributor

PoC for #2327

@github-actions
Copy link

github-actions bot commented Jul 6, 2023

@LaurenceJJones: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions
Copy link

github-actions bot commented Jul 6, 2023

@LaurenceJJones: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@LaurenceJJones
Copy link
Contributor Author

/kind enhancement
/area agent

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Attention: Patch coverage is 52.50000% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 58.18%. Comparing base (d1bfadd) to head (2700aa3).
Report is 149 commits behind head on master.

Files Patch % Lines
pkg/csprofiles/csprofiles.go 44.44% 12 Missing and 3 partials ⚠️
cmd/crowdsec-cli/notifications.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2345      +/-   ##
==========================================
+ Coverage   58.08%   58.18%   +0.09%     
==========================================
  Files         197      201       +4     
  Lines       26707    27107     +400     
==========================================
+ Hits        15514    15771     +257     
- Misses       9675     9783     +108     
- Partials     1518     1553      +35     
Flag Coverage Δ
bats 38.28% <35.00%> (-0.05%) ⬇️
unit-linux 55.21% <50.00%> (-0.03%) ⬇️
unit-windows 51.55% <44.44%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LaurenceJJones LaurenceJJones changed the title [WIP] Add notification filter to profiles [crowdsec] Add notification filter to profiles Jul 26, 2023
@LaurenceJJones LaurenceJJones marked this pull request as ready for review July 26, 2023 14:33
@LaurenceJJones LaurenceJJones added this to the 1.6.3 milestone Feb 23, 2024
@LaurenceJJones LaurenceJJones marked this pull request as draft February 23, 2024 13:39
@LaurenceJJones
Copy link
Contributor Author

Closing due to no-op from core team on the feature as it may cause too many confusion from user perspective, will close and in future if we need to re validate this idea we can

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/agent kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants