[postoverflow] Reinject meta into overflown state

[LaurenceJJones]

#1337

This one is difficult to find an appropriate fix..... since Meta is converted to events on "overflow" anything set in meta in postoverflow stage is never carried beyond. This PR re injects all meta objects across all events, to make sure the user has it.

I am primarily looking for feedback as I couldnt really see any other property without creating a new one but we already have too many "meta" properties.

[github-actions]

@LaurenceJJones: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

• /kind feature
• /kind enhancement
• /kind fix
• /kind chore
• /kind dependencies

Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

[github-actions]

@LaurenceJJones: There are no area labels on this PR. You can add as many areas as you see fit.

• /area agent
• /area local-api
• /area cscli
• /area security
• /area configuration

Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

[LaurenceJJones]

/kind enhancement
/area agent

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 57.95%. Comparing base (4bf640c) to head (dfee2f1).
Report is 146 commits behind head on master.

Files	Patch %	Lines
cmd/crowdsec/output.go	0.00%	8 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2502   +/-   ##
=======================================
  Coverage   57.94%   57.95%           
=======================================
  Files         240      240           
  Lines       31039    31048    +9     
=======================================
+ Hits        17986    17993    +7     
- Misses      11418    11421    +3     
+ Partials     1635     1634    -1     

Flag	Coverage Δ
bats	37.93% <0.00%> (+0.04%)	⬆️
unit-linux	52.30% <ø> (+0.03%)	⬆️
unit-windows	47.75% <ø> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sabban]

lgtm

[sabban]

lgtm

[sabban]

lgtm

[LaurenceJJones]

Converting to draft, as this implementation is pretty "mehhh" we should instead add a helper on the Alert or Overflown object to reinject it instead of magically just doing it as then users cant control the flow

[LaurenceJJones]

Closing for now due to concerns that re injecting the meta without any consideration from user perspective could cause confusion as we should control which alert in the post overflown is injected.