Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor waf fixes #2693

Merged
merged 3 commits into from
Jan 3, 2024
Merged

minor waf fixes #2693

merged 3 commits into from
Jan 3, 2024

Conversation

buixor
Copy link
Contributor

@buixor buixor commented Jan 3, 2024

  • do not bail out on missing host header
  • add eq operator
  • support negative match

Copy link

github-actions bot commented Jan 3, 2024

@buixor: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

github-actions bot commented Jan 3, 2024

@buixor: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (b6f272d) 55.18% compared to head (72a23f4) 55.12%.
Report is 3 commits behind head on master.

❗ Current head 72a23f4 differs from pull request most recent head 4411127. Consider uploading reports for the commit 4411127 to get more accurate results

Files Patch % Lines
pkg/appsec/request.go 0.00% 5 Missing ⚠️
pkg/acquisition/modules/appsec/appsec.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2693      +/-   ##
==========================================
- Coverage   55.18%   55.12%   -0.06%     
==========================================
  Files         227      227              
  Lines       30268    30332      +64     
==========================================
+ Hits        16702    16722      +20     
- Misses      11953    11990      +37     
- Partials     1613     1620       +7     
Flag Coverage Δ
bats 36.76% <0.00%> (+0.05%) ⬆️
unit-linux 49.67% <0.00%> (-0.04%) ⬇️
unit-windows 47.86% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LaurenceJJones
Copy link
Contributor

/kind enhancement
/area agent

Copy link
Contributor

@LaurenceJJones LaurenceJJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but let me know if you plan to use this PR for the others items

@buixor buixor merged commit 1c03fbe into master Jan 3, 2024
14 checks passed
@buixor buixor deleted the appsec-500-no-host-header branch January 3, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/agent kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants