Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apiserver/apiclient: lint #2695

Closed
wants to merge 1 commit into from
Closed

apiserver/apiclient: lint #2695

wants to merge 1 commit into from

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Jan 4, 2024

No description provided.

Copy link

github-actions bot commented Jan 4, 2024

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

github-actions bot commented Jan 4, 2024

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc added the kind/enhancement New feature or request label Jan 4, 2024
@mmetc mmetc added needs/kind kind/chore and removed kind/enhancement New feature or request labels Jan 4, 2024
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: Patch coverage is 28.78788% with 47 lines in your changes are missing coverage. Please review.

Project coverage is 57.91%. Comparing base (8e9e091) to head (7e83e91).

Files Patch % Lines
pkg/apiserver/papi.go 0.00% 20 Missing ⚠️
pkg/apiserver/controllers/v1/decisions.go 0.00% 19 Missing ⚠️
pkg/apiserver/papi_cmd.go 0.00% 4 Missing ⚠️
pkg/apiserver/middlewares/v1/jwt.go 50.00% 3 Missing ⚠️
pkg/apiserver/apic.go 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2695      +/-   ##
==========================================
- Coverage   57.98%   57.91%   -0.08%     
==========================================
  Files         240      236       -4     
  Lines       31040    30673     -367     
==========================================
- Hits        18000    17764     -236     
+ Misses      11411    11315      -96     
+ Partials     1629     1594      -35     
Flag Coverage Δ
bats 38.02% <19.69%> (+0.03%) ⬆️
unit-linux 52.28% <27.27%> (+0.01%) ⬆️
unit-windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc force-pushed the apiclient-apiserver branch 3 times, most recently from 1181444 to c1bd717 Compare January 10, 2024 11:03
@mmetc mmetc force-pushed the apiclient-apiserver branch 4 times, most recently from da4f34b to 7841414 Compare January 19, 2024 12:57
@mmetc mmetc closed this Feb 29, 2024
@mmetc mmetc deleted the apiclient-apiserver branch February 29, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant