Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact "cscli machines" #2777

Merged
merged 20 commits into from
Feb 1, 2024
Merged

refact "cscli machines" #2777

merged 20 commits into from
Feb 1, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Jan 24, 2024

No description provided.

@mmetc mmetc added the kind/enhancement New feature or request label Jan 24, 2024
@mmetc mmetc changed the title Cscli machines refact cscli machines Jan 24, 2024
Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc changed the title refact cscli machines refact cscli "machines" Jan 24, 2024
cmd/crowdsec-cli/machines.go Dismissed Show dismissed Hide dismissed
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 79 lines in your changes are missing coverage. Please review.

Comparison is base (4192af3) 56.91% compared to head (b3d71e9) 57.02%.

Files Patch % Lines
cmd/crowdsec-cli/machines.go 58.85% 66 Missing and 6 partials ⚠️
cmd/crowdsec-cli/flag.go 76.92% 3 Missing ⚠️
cmd/crowdsec-cli/main.go 57.14% 2 Missing and 1 partial ⚠️
cmd/crowdsec-cli/support.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2777      +/-   ##
==========================================
+ Coverage   56.91%   57.02%   +0.10%     
==========================================
  Files         237      238       +1     
  Lines       30632    30637       +5     
==========================================
+ Hits        17435    17471      +36     
+ Misses      11513    11490      -23     
+ Partials     1684     1676       -8     
Flag Coverage Δ
bats 36.83% <60.30%> (+0.09%) ⬆️
unit-linux 52.23% <ø> (ø)
unit-windows 47.76% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc changed the title refact cscli "machines" refact "cscli machines" Jan 24, 2024
@mmetc mmetc marked this pull request as ready for review January 31, 2024 12:56
@mmetc mmetc added this to the 1.6.1 milestone Jan 31, 2024
@mmetc mmetc merged commit 17db4cb into master Feb 1, 2024
17 checks passed
@mmetc mmetc deleted the cscli-machines branch February 1, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request needs/area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants