Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact "cscli <itemtype>" #2782

Merged
merged 1 commit into from
Feb 1, 2024
Merged

refact "cscli <itemtype>" #2782

merged 1 commit into from
Feb 1, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Jan 24, 2024

No description provided.

@mmetc mmetc added this to the 1.6.1 milestone Jan 24, 2024
Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (4192af3) 56.91% compared to head (fd36aad) 56.94%.

Files Patch % Lines
cmd/crowdsec-cli/itemcli.go 95.77% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2782      +/-   ##
==========================================
+ Coverage   56.91%   56.94%   +0.02%     
==========================================
  Files         237      233       -4     
  Lines       30632    30223     -409     
==========================================
- Hits        17435    17211     -224     
+ Misses      11513    11380     -133     
+ Partials     1684     1632      -52     
Flag Coverage Δ
bats 36.85% <95.83%> (+0.11%) ⬆️
unit-linux 52.23% <ø> (+<0.01%) ⬆️
unit-windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc added the kind/enhancement New feature or request label Jan 24, 2024
@mmetc mmetc force-pushed the cscli-items branch 2 times, most recently from 1f2384e to 9a8f0b8 Compare January 30, 2024 14:39
@mmetc mmetc marked this pull request as draft January 30, 2024 21:48
@mmetc mmetc marked this pull request as ready for review January 31, 2024 14:17
@mmetc mmetc merged commit af14f10 into master Feb 1, 2024
17 checks passed
@mmetc mmetc deleted the cscli-items branch February 1, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request needs/area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants