refact "cscli metrics" part 3

[mmetc]

• missing a couple tests for "metrics list" and "metrics show"
• the help text for "cscli metrics" should be changed (different than "cscli metrics show")
• "cscli metrics show" requires at least one section name, could be optional to show them all
• I think we should we display empty tables if explicitly required? We do it for json/raw
• metrics list should maybe add a description for each table? and support -o json

[github-actions]

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

• /kind feature
• /kind enhancement
• /kind fix
• /kind chore
• /kind dependencies

Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

[github-actions]

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

• /area agent
• /area local-api
• /area cscli
• /area appsec
• /area security
• /area configuration

Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

[codecov]

Codecov Report

Attention: 31 lines in your changes are missing coverage. Please review.

Comparison is base (81acad0) 57.27% compared to head (60cb82b) 57.60%.

Files	Patch %	Lines
cmd/crowdsec-cli/metrics_table.go	79.54%	11 Missing and 7 partials ⚠️
cmd/crowdsec-cli/metrics.go	93.75%	8 Missing and 3 partials ⚠️
cmd/crowdsec-cli/support.go	71.42%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2807      +/-   ##
==========================================
+ Coverage   57.27%   57.60%   +0.32%     
==========================================
  Files         238      238              
  Lines       30584    30748     +164     
==========================================
+ Hits        17518    17712     +194     
+ Misses      11415    11389      -26     
+ Partials     1651     1647       -4     

Flag	Coverage Δ
bats	37.52% <88.64%> (+0.42%)	⬆️
unit-linux	52.22% <ø> (-0.01%)	⬇️
unit-windows	47.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[buixor]

code structure

[buixor]

maybe add some long examples with the most useful show subsections :)