Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appsec: get the original UA from headers #2809

Merged
merged 4 commits into from
Mar 8, 2024
Merged

Conversation

blotus
Copy link
Member

@blotus blotus commented Feb 2, 2024

Closes #2787

Copy link

github-actions bot commented Feb 2, 2024

@blotus: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

github-actions bot commented Feb 2, 2024

@blotus: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@blotus
Copy link
Member Author

blotus commented Feb 2, 2024

/area appsec
/kind fix

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 57.94%. Comparing base (4bf640c) to head (a871e2f).

Files Patch % Lines
pkg/appsec/request.go 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2809      +/-   ##
==========================================
- Coverage   57.94%   57.94%   -0.01%     
==========================================
  Files         240      240              
  Lines       31039    31049      +10     
==========================================
+ Hits        17986    17990       +4     
- Misses      11418    11426       +8     
+ Partials     1635     1633       -2     
Flag Coverage Δ
bats 37.91% <0.00%> (+0.01%) ⬆️
unit-linux 52.25% <0.00%> (-0.01%) ⬇️
unit-windows 47.73% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@buixor buixor self-requested a review February 2, 2024 13:46
@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 57.97%. Comparing base (98560d0) to head (a01b669).
Report is 1 commits behind head on master.

Files Patch % Lines
pkg/appsec/request.go 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2809      +/-   ##
==========================================
- Coverage   57.99%   57.97%   -0.02%     
==========================================
  Files         240      240              
  Lines       31094    31104      +10     
==========================================
  Hits        18034    18034              
- Misses      11432    11442      +10     
  Partials     1628     1628              
Flag Coverage Δ
bats 38.01% <0.00%> (+0.04%) ⬆️
unit-linux 52.26% <0.00%> (-0.02%) ⬇️
unit-windows 47.75% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@LaurenceJJones LaurenceJJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blotus blotus merged commit e8ff13b into master Mar 8, 2024
15 checks passed
@blotus blotus deleted the appsec-user-agent-header branch March 8, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AppSec] User user-agent is not forwarded to AppSec
3 participants