Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact "cscli alerts" #2827

Merged
merged 3 commits into from
Feb 9, 2024
Merged

refact "cscli alerts" #2827

merged 3 commits into from
Feb 9, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Feb 9, 2024

No description provided.

@mmetc mmetc added kind/enhancement New feature or request area/cscli labels Feb 9, 2024
@mmetc mmetc added this to the 1.6.1 milestone Feb 9, 2024
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (332af5d) 57.74% compared to head (aef9ca5) 57.76%.

Files Patch % Lines
cmd/crowdsec-cli/alerts.go 78.40% 13 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2827      +/-   ##
==========================================
+ Coverage   57.74%   57.76%   +0.01%     
==========================================
  Files         238      238              
  Lines       30867    30882      +15     
==========================================
+ Hits        17824    17838      +14     
- Misses      11395    11396       +1     
  Partials     1648     1648              
Flag Coverage Δ
bats 37.66% <78.65%> (+0.01%) ⬆️
unit-linux 52.40% <ø> (+0.02%) ⬆️
unit-windows 47.80% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc merged commit 2853410 into master Feb 9, 2024
17 checks passed
@mmetc mmetc deleted the cscli-alerts branch February 9, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cscli kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants