Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact "cscli config" #2832

Merged
merged 7 commits into from
Feb 22, 2024
Merged

refact "cscli config" #2832

merged 7 commits into from
Feb 22, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Feb 11, 2024

No description provided.

@mmetc mmetc added the kind/enhancement New feature or request label Feb 11, 2024
@mmetc mmetc added this to the 1.6.1 milestone Feb 11, 2024
Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Feb 11, 2024

Codecov Report

Attention: 61 lines in your changes are missing coverage. Please review.

Comparison is base (f3ea88f) 57.87% compared to head (115c356) 57.93%.

Files Patch % Lines
cmd/crowdsec-cli/config_restore.go 38.46% 25 Missing and 7 partials ⚠️
cmd/crowdsec-cli/config_backup.go 46.66% 18 Missing and 6 partials ⚠️
cmd/crowdsec-cli/config_feature_flags.go 63.63% 3 Missing and 1 partial ⚠️
cmd/crowdsec-cli/config_show.go 94.44% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2832      +/-   ##
==========================================
+ Coverage   57.87%   57.93%   +0.06%     
==========================================
  Files         239      239              
  Lines       31028    30983      -45     
==========================================
- Hits        17958    17951       -7     
+ Misses      11436    11399      -37     
+ Partials     1634     1633       -1     
Flag Coverage Δ
bats 37.87% <58.21%> (-0.02%) ⬇️
unit-linux 52.29% <ø> (+<0.01%) ⬆️
unit-windows 47.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc merged commit 3e3df5e into master Feb 22, 2024
17 checks passed
@mmetc mmetc deleted the cscli-config branch February 22, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cscli kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants