Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact pkg/apiclient #2846

Merged
merged 4 commits into from
Feb 22, 2024
Merged

refact pkg/apiclient #2846

merged 4 commits into from
Feb 22, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Feb 14, 2024

No description provided.

@mmetc mmetc added kind/enhancement New feature or request area/agent labels Feb 14, 2024
@mmetc mmetc added this to the 1.6.1 milestone Feb 14, 2024
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (717fc97) 57.88% compared to head (4022e3f) 57.89%.
Report is 3 commits behind head on master.

Files Patch % Lines
pkg/apiclient/resperr.go 66.66% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2846   +/-   ##
=======================================
  Coverage   57.88%   57.89%           
=======================================
  Files         239      240    +1     
  Lines       30993    31032   +39     
=======================================
+ Hits        17941    17966   +25     
- Misses      11415    11432   +17     
+ Partials     1637     1634    -3     
Flag Coverage Δ
bats 37.85% <81.57%> (+0.06%) ⬆️
unit-linux 52.31% <78.94%> (-0.04%) ⬇️
unit-windows 47.78% <78.94%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@LaurenceJJones LaurenceJJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmetc mmetc merged commit 8da490f into master Feb 22, 2024
17 checks passed
@mmetc mmetc deleted the apiclient-refact branch February 22, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/agent kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants