Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact cscli (globals) #2854

Merged
merged 4 commits into from
Feb 23, 2024
Merged

refact cscli (globals) #2854

merged 4 commits into from
Feb 23, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Feb 22, 2024

avoid direct access to csConfig

Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc changed the title refact cscli refact cscli (globals) Feb 22, 2024
Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc added kind/enhancement New feature or request area/cscli labels Feb 22, 2024
cmd/crowdsec-cli/capi.go Dismissed Show dismissed Hide dismissed
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 56.22490% with 109 lines in your changes are missing coverage. Please review.

Project coverage is 57.98%. Comparing base (0df8f54) to head (78362ca).

Files Patch % Lines
cmd/crowdsec-cli/hubtest.go 45.88% 46 Missing ⚠️
cmd/crowdsec-cli/capi.go 68.90% 27 Missing and 10 partials ⚠️
cmd/crowdsec-cli/config_restore.go 33.33% 13 Missing and 7 partials ⚠️
cmd/crowdsec-cli/bouncers.go 53.84% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2854      +/-   ##
==========================================
+ Coverage   57.96%   57.98%   +0.02%     
==========================================
  Files         240      240              
  Lines       30992    31035      +43     
==========================================
+ Hits        17965    17997      +32     
- Misses      11396    11408      +12     
+ Partials     1631     1630       -1     
Flag Coverage Δ
bats 37.90% <56.22%> (-0.01%) ⬇️
unit-linux 52.32% <ø> (ø)
unit-windows 47.80% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc removed the needs/area label Feb 22, 2024
@mmetc mmetc added this to the 1.6.1 milestone Feb 22, 2024
Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc merged commit e34af35 into master Feb 23, 2024
17 checks passed
@mmetc mmetc deleted the global-cscli-capi branch February 23, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cscli kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants