Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact pkg/apiserver (auth helpers) #2856

Merged
merged 1 commit into from
Feb 23, 2024
Merged

refact pkg/apiserver (auth helpers) #2856

merged 1 commit into from
Feb 23, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Feb 22, 2024

No description provided.

Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc
Copy link
Contributor Author

mmetc commented Feb 22, 2024

Required for the metrics. It would probably make sense to move the two helpers to middlewares/v1, since that's where they are appended to context.

@mmetc mmetc added this to the 1.6.1 milestone Feb 22, 2024
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 57.93%. Comparing base (0df8f54) to head (1b8d34e).

Files Patch % Lines
pkg/apiserver/controllers/v1/utils.go 33.33% 9 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2856      +/-   ##
==========================================
- Coverage   57.96%   57.93%   -0.04%     
==========================================
  Files         240      240              
  Lines       30992    30996       +4     
==========================================
- Hits        17965    17956       -9     
- Misses      11396    11405       +9     
- Partials     1631     1635       +4     
Flag Coverage Δ
bats 37.83% <66.66%> (-0.07%) ⬇️
unit-linux 52.28% <69.23%> (-0.04%) ⬇️
unit-windows 47.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc requested a review from blotus February 23, 2024 09:20
@mmetc mmetc merged commit 4bf640c into master Feb 23, 2024
21 checks passed
@mmetc mmetc deleted the lapi-metrics branch February 23, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants