Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/cwhub: download data assets to temporary files to avoid partial fetch #2879

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Mar 8, 2024

No description provided.

Copy link

github-actions bot commented Mar 8, 2024

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

github-actions bot commented Mar 8, 2024

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc added this to the 1.6.1 milestone Mar 8, 2024
@mmetc mmetc requested review from blotus and removed request for blotus March 8, 2024 08:40
@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 63.15789% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 47.59%. Comparing base (1eab943) to head (fb9ee40).

Files Patch % Lines
pkg/cwhub/dataset.go 57.14% 4 Missing and 2 partials ⚠️
pkg/cwhub/hub.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2879      +/-   ##
==========================================
- Coverage   52.86%   47.59%   -5.28%     
==========================================
  Files         242      143      -99     
  Lines       31208    18070   -13138     
==========================================
- Hits        16498     8600    -7898     
+ Misses      13135     8525    -4610     
+ Partials     1575      945     -630     
Flag Coverage Δ
bats ?
unit-windows 47.59% <63.15%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc changed the title pkg/cwhub: download data assets to a temporary file to avoid partial fetch pkg/cwhub: download data assets to temporary files to avoid partial fetch Mar 8, 2024
@mmetc mmetc merged commit 6c5e8af into master Mar 8, 2024
15 checks passed
@mmetc mmetc deleted the download-tmp branch March 8, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants