Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[appsec] delete api key header before processing the request #2890

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

blotus
Copy link
Member

@blotus blotus commented Mar 13, 2024

Fix #2888

Copy link

@blotus: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@blotus: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@blotus
Copy link
Member Author

blotus commented Mar 13, 2024

/kind fix
/area appsec

@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 47.58%. Comparing base (bd785ed) to head (4fbd5f4).

Files Patch % Lines
pkg/appsec/request.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2890       +/-   ##
===========================================
- Coverage   58.16%   47.58%   -10.59%     
===========================================
  Files         242      143       -99     
  Lines       31238    18091    -13147     
===========================================
- Hits        18171     8609     -9562     
+ Misses      11409     8537     -2872     
+ Partials     1658      945      -713     
Flag Coverage Δ
bats ?
unit-linux ?
unit-windows 47.58% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@buixor buixor added this to the 1.6.1 milestone Mar 14, 2024
@blotus blotus merged commit 742f5e8 into master Mar 14, 2024
15 checks passed
@blotus blotus deleted the appsec-delete-api-key branch March 14, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AppSec] Api key header is not delete before it processed by coraza
4 participants