-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add possibility to configure log format #799 #2941
base: master
Are you sure you want to change the base?
Conversation
@victoredvardsson: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
@victoredvardsson: There are no area labels on this PR. You can add as many areas as you see fit.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
/kind feature |
/area configuration |
…ogFormatter) is not undefined when function is called
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2941 +/- ##
===========================================
+ Coverage 27.54% 38.85% +11.30%
===========================================
Files 398 399 +1
Lines 57920 57952 +32
===========================================
+ Hits 15954 22515 +6561
+ Misses 40028 32951 -7077
- Partials 1938 2486 +548
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Looks like all checks went through now 👍 |
I still need to add a formatter for stderr when the rest of the messages goes to a file. We don't want fatal errors to be formatted in json for this case. Will do asap and merge for 1.6.2 |
merge is postponed to 1.6.3 since I'd like to correctly bubble up errors from goroutines and 1.6.2 is too soon |
We keeping |
Next one, I'd rather remove the remaining os.Exit and log.Fatal before implementing this |
#799
logrus which is used as logging backend supports json formatter.
This change makes it possible to configure either text or json output.