Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update checks for wrapped errors #3117

Merged
merged 4 commits into from
Nov 4, 2024
Merged

update checks for wrapped errors #3117

merged 4 commits into from
Nov 4, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Jul 9, 2024

No description provided.

@mmetc mmetc added this to the 1.6.3 milestone Jul 9, 2024
Copy link

github-actions bot commented Jul 9, 2024

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

github-actions bot commented Jul 9, 2024

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 58.32%. Comparing base (1616991) to head (9bda524).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/acquisition/modules/appsec/appsec.go 0.00% 7 Missing ⚠️
pkg/apiserver/apiserver.go 50.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3117      +/-   ##
==========================================
- Coverage   58.32%   58.32%   -0.01%     
==========================================
  Files         349      349              
  Lines       37389    37395       +6     
==========================================
+ Hits        21808    21809       +1     
- Misses      13693    13699       +6     
+ Partials     1888     1887       -1     
Flag Coverage Δ
bats 41.47% <29.41%> (-0.02%) ⬇️
unit-linux 34.07% <29.41%> (-0.02%) ⬇️
unit-windows 29.29% <40.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc changed the title update check for wrapped errors update checks for wrapped errors Jul 9, 2024
@mmetc mmetc removed this from the 1.6.3 milestone Jul 9, 2024
@mmetc mmetc force-pushed the errorlint branch 3 times, most recently from 88b56b9 to ac69c63 Compare July 24, 2024 09:02
@mmetc mmetc added this to the 1.6.4 milestone Jul 24, 2024
@mmetc mmetc force-pushed the errorlint branch 3 times, most recently from 89ad767 to 32940a5 Compare August 22, 2024 07:36
@mmetc mmetc force-pushed the errorlint branch 3 times, most recently from 73eac59 to ef687bc Compare September 3, 2024 11:34
@mmetc mmetc force-pushed the errorlint branch 2 times, most recently from 723de5f to 33ace3b Compare September 17, 2024 12:47
@mmetc mmetc force-pushed the errorlint branch 2 times, most recently from e1a40ab to f9bc6fe Compare October 10, 2024 09:12
@mmetc mmetc requested a review from blotus October 10, 2024 09:12
@mmetc mmetc force-pushed the errorlint branch 3 times, most recently from b31265b to bc15750 Compare October 28, 2024 16:10
@mmetc mmetc merged commit 5752111 into master Nov 4, 2024
17 checks passed
@mmetc mmetc deleted the errorlint branch November 4, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants