Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: force hub index file update if hub data upgrade is forced #3124

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nox-x
Copy link

@nox-x nox-x commented Jul 11, 2024

I ran into an issue by having a hub-index file younger than 24h within the docker container and needed to restart it while the hub holds newer data.
So this results in conflicting hashes for parsers loaded by a collection.

Setting the environment var DO_HUB_UPGRADE to true it just forces the already (old) indexed collections to upgrade, but not upgrading the index file.
I think if someone forcing to get the newest data from the hub, than the local index should be as fresh as possible.

With this PR setting DO_HUB_UPGRADE to true also forces the local hub index to get updated on starting the docker container.

Copy link

@nox-x: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@nox-x: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@nox-x
Copy link
Author

nox-x commented Jul 11, 2024

/kind enhancement
/area configuration

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.87%. Comparing base (1b01041) to head (89142ac).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3124       +/-   ##
===========================================
+ Coverage   32.05%   49.87%   +17.82%     
===========================================
  Files         320      321        +1     
  Lines       37662    37664        +2     
===========================================
+ Hits        12073    18786     +6713     
+ Misses      24287    17055     -7232     
- Partials     1302     1823      +521     
Flag Coverage Δ
bats 38.47% <ø> (?)
unit-linux 34.42% <ø> (ø)
unit-windows 29.06% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LaurenceJJones LaurenceJJones added this to the 1.6.4 milestone Jul 12, 2024
@buixor buixor modified the milestones: 1.6.4, 1.6.5 Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants