Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact pkg/database: clean up code and error messages #3263

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

refact pkg/database: extract function rollbackOnError(); dry error me…

72e2589
Select commit
Loading
Failed to load commit list.
Open

refact pkg/database: clean up code and error messages #3263

refact pkg/database: extract function rollbackOnError(); dry error me…
72e2589
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 4, 2024 in 0s

58.33% (target 0.00%)

View this Pull Request on Codecov

58.33% (target 0.00%)

Details

Codecov Report

Attention: Patch coverage is 82.35294% with 39 lines in your changes missing coverage. Please review.

Project coverage is 58.33%. Comparing base (5752111) to head (72e2589).

Files with missing lines Patch % Lines
pkg/database/alertfilter.go 86.53% 20 Missing and 8 partials ⚠️
pkg/database/alerts.go 0.00% 10 Missing ⚠️
pkg/types/ip.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3263      +/-   ##
==========================================
+ Coverage   58.30%   58.33%   +0.02%     
==========================================
  Files         349      350       +1     
  Lines       37395    37373      -22     
==========================================
- Hits        21805    21801       -4     
+ Misses      13702    13684      -18     
  Partials     1888     1888              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.