Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit configuration for signals sharing and blocklists pull #3277

Merged
merged 11 commits into from
Nov 8, 2024

Conversation

blotus
Copy link
Member

@blotus blotus commented Oct 3, 2024

Fixes #3188.

This PR adds 3 new config options:

  • server.online_client.sharing: Should crowdsec send alerts to CAPI? Defaults to true.
  • server.online_client.pull.community: When querying the decision stream in CAPI, should we get the content of the community blocklist ? Defaults to true.
  • server.online_client.pull.blocklists: When querying the decision stream in CAPI. should we get the content of additional blocklists the instance is subscribed to ? Defaults to true.

This goes a bit beyond the scope of the initial issue, but the added granularity is probably worth it (for example, only push signals with no pull when running a honeypot, only pull additional blocklist if you use the console to distribute custom lists,...)

@blotus blotus added this to the 1.6.4 milestone Oct 3, 2024
Copy link

github-actions bot commented Oct 3, 2024

@blotus: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

github-actions bot commented Oct 3, 2024

@blotus: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@blotus
Copy link
Member Author

blotus commented Oct 9, 2024

/kind enhancement
/area local-api

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 75.80645% with 15 lines in your changes missing coverage. Please review.

Project coverage is 58.49%. Comparing base (94a2a58) to head (9c733cc).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/apiserver/apic.go 70.96% 8 Missing and 1 partial ⚠️
cmd/crowdsec-cli/clicapi/capi.go 60.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3277       +/-   ##
===========================================
+ Coverage   41.28%   58.49%   +17.21%     
===========================================
  Files         333      351       +18     
  Lines       36250    37676     +1426     
===========================================
+ Hits        14966    22040     +7074     
+ Misses      19809    13740     -6069     
- Partials     1475     1896      +421     
Flag Coverage Δ
bats 41.32% <64.51%> (+0.03%) ⬆️
unit-linux 34.46% <61.29%> (?)
unit-windows 29.68% <61.29%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blotus blotus merged commit 5d414f5 into master Nov 8, 2024
17 checks passed
@blotus blotus deleted the capi-granular-configuration branch November 8, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAPI] Configuration to enable / disable sending signals
2 participants