Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add HTTP datasource #3294

Merged
merged 34 commits into from
Nov 5, 2024
Merged

add HTTP datasource #3294

merged 34 commits into from
Nov 5, 2024

Conversation

he2ss
Copy link
Member

@he2ss he2ss commented Oct 23, 2024

feature : #3289

Copy link

@he2ss: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@he2ss: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@he2ss
Copy link
Member Author

he2ss commented Oct 23, 2024

/kind feature
/area agent

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 80.44164% with 62 lines in your changes missing coverage. Please review.

Project coverage is 58.46%. Comparing base (1616991) to head (aadc31a).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/acquisition/modules/http/http.go 81.17% 34 Missing and 14 partials ⚠️
pkg/acquisition/acquisition.go 0.00% 12 Missing ⚠️
pkg/acquisition/http.go 50.00% 0 Missing and 1 partial ⚠️
...isition/modules/wineventlog/wineventlog_windows.go 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3294      +/-   ##
==========================================
+ Coverage   58.32%   58.46%   +0.13%     
==========================================
  Files         349      351       +2     
  Lines       37389    37626     +237     
==========================================
+ Hits        21808    21998     +190     
- Misses      13693    13731      +38     
- Partials     1888     1897       +9     
Flag Coverage Δ
bats 41.28% <4.80%> (-0.22%) ⬇️
unit-linux 34.40% <80.44%> (+0.31%) ⬆️
unit-windows 29.62% <74.36%> (+0.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mmetc mmetc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The datasource_http tag should be listed in the Makefile too.

@blotus blotus merged commit 19b70f1 into master Nov 5, 2024
17 checks passed
@blotus blotus deleted the feat/acquisition/add-http-datasource branch November 5, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants