Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple appsec configs #3314

Merged
merged 8 commits into from
Nov 15, 2024
Merged

Support multiple appsec configs #3314

merged 8 commits into from
Nov 15, 2024

Conversation

buixor
Copy link
Contributor

@buixor buixor commented Nov 4, 2024

cf. #2999

  • Allow AppSec to load multip appsec config at once (rules & hooks are appended, for mutually exclusive options, last value is taken into account)

Copy link

github-actions bot commented Nov 4, 2024

@buixor: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

github-actions bot commented Nov 4, 2024

@buixor: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 19.31818% with 71 lines in your changes missing coverage. Please review.

Project coverage is 58.41%. Comparing base (a4497da) to head (7f57744).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/appsec/appsec.go 0.00% 53 Missing ⚠️
pkg/acquisition/modules/appsec/appsec.go 0.00% 15 Missing ⚠️
pkg/acquisition/modules/appsec/appsec_runner.go 85.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3314      +/-   ##
==========================================
- Coverage   58.53%   58.41%   -0.12%     
==========================================
  Files         351      351              
  Lines       37676    37746      +70     
==========================================
- Hits        22054    22050       -4     
- Misses      13729    13798      +69     
- Partials     1893     1898       +5     
Flag Coverage Δ
bats 41.17% <0.00%> (-0.15%) ⬇️
unit-linux 34.42% <19.31%> (-0.05%) ⬇️
unit-windows 29.66% <19.31%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blotus blotus added this to the 1.6.4 milestone Nov 8, 2024
@blotus
Copy link
Member

blotus commented Nov 15, 2024

/kind enhancement

@blotus
Copy link
Member

blotus commented Nov 15, 2024

/area appsec

@buixor buixor changed the title [WIP] support multiple appsec configs Support multiple appsec configs Nov 15, 2024
@buixor buixor merged commit 9067106 into master Nov 15, 2024
17 checks passed
@buixor buixor deleted the multi_appsec_configs branch November 15, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/appsec kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants