Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loki: add no_ready_check option #3317

Merged
merged 4 commits into from
Nov 8, 2024
Merged

loki: add no_ready_check option #3317

merged 4 commits into from
Nov 8, 2024

Conversation

blotus
Copy link
Member

@blotus blotus commented Nov 7, 2024

When using Loki hosted in Grafana cloud, the /ready endpoint does not exist, which prevents crowdsec from starting.

Add an option to bypass this check.
Defaults to false to keep the same behavior by default.

Copy link

github-actions bot commented Nov 7, 2024

@blotus: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

github-actions bot commented Nov 7, 2024

@blotus: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@blotus
Copy link
Member Author

blotus commented Nov 7, 2024

/kind enhancement
/area agent

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 73.07692% with 7 lines in your changes missing coverage. Please review.

Project coverage is 58.46%. Comparing base (19b70f1) to head (437223d).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/acquisition/modules/loki/loki.go 73.07% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3317   +/-   ##
=======================================
  Coverage   58.45%   58.46%           
=======================================
  Files         351      351           
  Lines       37626    37631    +5     
=======================================
+ Hits        21996    22000    +4     
- Misses      13732    13733    +1     
  Partials     1898     1898           
Flag Coverage Δ
bats 41.25% <0.00%> (-0.01%) ⬇️
unit-linux 34.40% <73.07%> (-0.01%) ⬇️
unit-windows 29.65% <11.53%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blotus blotus merged commit 94a2a58 into master Nov 8, 2024
17 checks passed
@blotus blotus deleted the loki-bypass-ready-check branch November 8, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/agent kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants